feat(web-ongoing-operations): fix translate keys by louisbensiovh · Pull Request #23010 · ovh/manager

louisbensiovh · 2026-07-09T08:21:44Z

Description

Modify the translate keys

Ticket Reference: #DCE-218

Copilot

Pull request overview

This PR updates the i18n translation key pattern used by the “string argument” update UI in web-ongoing-operations, aligning labels with the domain_operations_update_* namespace (ticket DCE-218).

Changes:

Update UpdateStringComponent to use domain_operations_update_${argumentKey} instead of domain_operations_update_key_${argumentKey}.
Rename a subset of French (fr_FR) translation keys to the new pattern.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
packages/manager/apps/web-ongoing-operations/src/components/Update/Content/Update.String.component.tsx	Switches the translation key format used for string-argument field labels.
packages/manager/apps/web-ongoing-operations/public/translations/dashboard/Messages_fr_FR.json	Renames several `domain_operations_update_key_` entries to `domain_operations_update_` in French translations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

louisbensiovh · 2026-07-09T08:27:18Z

      <FormField className="w-1/4" invalid={error != null && error.length > 0}>
        <FormFieldLabel>
-          {t(`domain_operations_update_key_${argumentKey}`)}
+          {t(`domain_operations_update_${argumentKey}`)}


Using translator fast pass to correct this

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

      <FormField className="w-1/4" invalid={error != null && error.length > 0}>
        <FormFieldLabel>
-          {t(`domain_operations_update_key_${argumentKey}`)}
+          {t(`domain_operations_update_${argumentKey}`)}


Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

      <FormField className="w-1/4" invalid={error != null && error.length > 0}>
        <FormFieldLabel>
-          {t(`domain_operations_update_key_${argumentKey}`)}
+          {t(`domain_operations_update_${argumentKey}`)}


Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

      <FormField className="w-1/4" invalid={error != null && error.length > 0}>
        <FormFieldLabel>
-          {t(`domain_operations_update_key_${argumentKey}`)}
+          {t(`domain_operations_update_${argumentKey}`.toLowerCase())}


              <li key={item} className="font-bold text-[var(--ods-color-text)]">
-                {t(`domain_operations_update_${item}`)}
+                {t(`domain_operations_update_${item}`.toLowerCase())}
              </li>


        {t(
          `domain_operations_update_nicowner_click_${argumentKey === 'corporationProof' ? 'nicowner' : argumentKey ?? ''
-          }`,
+          }`.toLowerCase(),
        )}


        }}
      >
-        {t(`domain_operations_update_${argumentKey}_click`)}
+        {t(`domain_operations_update_${argumentKey}_click`.toLowerCase())}


ref: #DCE-218 Signed-off-by: Louis BENSI <louis.bensi@corp.ovh.com>

Fresh pnpm installs resolved the transitive @types/react to 19.2.17 while the app runs React 18.2.0, producing 94 TS2786/TS2345 errors (React 18/19 type mismatch). Pinning @types/react and @types/react-dom in devDependencies lets manager-pm's critical-deps normalization keep them on v18, like every other pnpm-managed app. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

      <FormField className="w-1/4" invalid={error != null && error.length > 0}>
        <FormFieldLabel>
-          {t(`domain_operations_update_key_${argumentKey}`)}
+          {t(`domain_operations_update_${argumentKey}`.toLowerCase())}


            {fields.map((item) => (
              <li key={item} className="font-bold text-[var(--ods-color-text)]">
-                {t(`domain_operations_update_${item}`)}
+                {t(`domain_operations_update_${item}`.toLowerCase())}


        {t(
          `domain_operations_update_nicowner_click_${argumentKey === 'corporationProof' ? 'nicowner' : argumentKey ?? ''
-          }`,
+          }`.toLowerCase(),
        )}


+  "domain_operations_update_name": "Nom",
+  "domain_operations_update_uklegalform": "Forme légale",


Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

      <FormField className="w-1/4" invalid={error != null && error.length > 0}>
        <FormFieldLabel>
-          {t(`domain_operations_update_key_${argumentKey}`)}
+          {t(`domain_operations_update_${argumentKey}`.toLowerCase())}


            {fields.map((item) => (
              <li key={item} className="font-bold text-[var(--ods-color-text)]">
-                {t(`domain_operations_update_${item}`)}
+                {t(`domain_operations_update_${item}`.toLowerCase())}


        {t(
          `domain_operations_update_nicowner_click_${argumentKey === 'corporationProof' ? 'nicowner' : argumentKey ?? ''
-          }`,
+          }`.toLowerCase(),
        )}


        }}
      >
-        {t(`domain_operations_update_${argumentKey}_click`)}
+        {t(`domain_operations_update_${argumentKey}_click`.toLowerCase())}


+  "domain_operations_update_firstname": "Prénom",
+  "domain_operations_update_name": "Nom",
+  "domain_operations_update_uklegalform": "Forme légale",
+  "domain_operations_update_nationalidentificationnumber": "Code fiscal",
+  "domain_operations_update_identificationnumber": "Numéro d'identification",


Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Signed-off-by: CDS Translator Agent <opensource@ovh.net>

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Copilot AI review requested due to automatic review settings July 9, 2026 08:21

louisbensiovh requested a review from a team as a code owner July 9, 2026 08:21

louisbensiovh requested review from SBrendan, kb-ovh and nfoufeovh July 9, 2026 08:21

Copilot started reviewing on behalf of louisbensiovh July 9, 2026 08:22 View session

github-actions Bot added universe-web-cloud translation required bug Something isn't working labels Jul 9, 2026

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 9, 2026 08:47

Copilot started reviewing on behalf of louisbensiovh July 9, 2026 08:50 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 9, 2026 08:52

louisbensiovh force-pushed the fix/DCE-218 branch from 419c0db to 77c65bf Compare July 9, 2026 08:52

Copilot started reviewing on behalf of louisbensiovh July 9, 2026 08:52 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 9, 2026 09:35

Copilot AI reviewed Jul 9, 2026

Copilot AI review requested due to automatic review settings July 9, 2026 15:26

louisbensiovh force-pushed the fix/DCE-218 branch from 0bc4007 to 4852fbc Compare July 9, 2026 15:26

Copilot started reviewing on behalf of louisbensiovh July 9, 2026 15:26 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 15, 2026 13:09

louisbensiovh requested a review from a team as a code owner July 15, 2026 13:10

louisbensiovh requested review from FabienHenon, anooparveti and clementdemily July 15, 2026 13:10

Copilot started reviewing on behalf of louisbensiovh July 15, 2026 13:10 View session

github-actions Bot added the dependencies Pull requests that update a dependency file label Jul 15, 2026

louisbensiovh removed the translation required label Jul 16, 2026

louisbensiovh requested review from Copilot and removed request for a team, FabienHenon, anooparveti and clementdemily July 16, 2026 20:41

Copilot started reviewing on behalf of louisbensiovh July 17, 2026 07:11 View session

github-actions Bot added the translation required label Jul 17, 2026

louisbensiovh force-pushed the fix/DCE-218 branch 2 times, most recently from e7f09b3 to 8b9c480 Compare July 17, 2026 07:14

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 17, 2026 07:15

Copilot started reviewing on behalf of louisbensiovh July 17, 2026 07:16 View session

louisbensiovh and others added 2 commits July 17, 2026 09:19

feat(web-ongoing-operations): fix translate keys

f0cd0e6

ref: #DCE-218 Signed-off-by: Louis BENSI <louis.bensi@corp.ovh.com>

louisbensiovh force-pushed the fix/DCE-218 branch from 8b9c480 to 8f6f92e Compare July 17, 2026 07:19

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 17, 2026 07:21

Copilot started reviewing on behalf of louisbensiovh July 17, 2026 07:21 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 17, 2026 07:30

Copilot AI reviewed Jul 17, 2026

louisbensiovh removed the translation required label Jul 17, 2026

kb-ovh previously approved these changes Jul 17, 2026

View reviewed changes

louisbensiovh dismissed kb-ovh’s stale review via 8f6f92e July 17, 2026 14:25

louisbensiovh force-pushed the fix/DCE-218 branch from 54d1721 to 8f6f92e Compare July 17, 2026 14:25

github-actions Bot added the translation required label Jul 17, 2026

fix(i18n): add missing translations [CDS 1283]

ae5a265

Signed-off-by: CDS Translator Agent <opensource@ovh.net>

Copilot AI review requested due to automatic review settings July 17, 2026 14:34

Copilot AI reviewed Jul 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(web-ongoing-operations): fix translate keys#23010

feat(web-ongoing-operations): fix translate keys#23010
louisbensiovh wants to merge 3 commits into
masterfrom
fix/DCE-218

louisbensiovh commented Jul 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

louisbensiovh Jul 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		"domain_operations_update_name": "Nom",
		"domain_operations_update_uklegalform": "Forme légale",

Uh oh!

Conversation

louisbensiovh commented Jul 9, 2026

Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

louisbensiovh Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants